Terraform support for Category and Term Resources by Sachin-Rungta · Pull Request #13923 · GoogleCloudPlatform/magic-modules

Sachin-Rungta · 2025-05-13T07:23:42Z

Release Note Template for Downstream PRs (will be copied)

`google_dataplex_glossary_category`

`google_dataplex_glossary_term`

modular-magician · 2025-05-16T06:01:28Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T06:06:18Z

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexGlossaryCategory_update

TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

modular-magician · 2025-05-16T06:07:00Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-16T06:09:10Z

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexGlossaryCategory_update

TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

modular-magician · 2025-05-16T06:09:11Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2006 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T06:09:52Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-16T06:16:36Z

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexGlossaryCategory_update

TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

modular-magician · 2025-05-16T06:17:36Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-16T06:37:58Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 2010 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 11 files changed, 2010 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T06:45:10Z

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexGlossaryCategory_update

TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

modular-magician · 2025-05-16T06:50:56Z

🔴 Tests failed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Error message] [Debug log]
TestAccDataplexGlossaryTerm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-05-16T07:13:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 2016 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 13 files changed, 2016 insertions(+), 8 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 216 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 456 insertions(+))

Multiple resources added

This PR adds multiple new resources: google_dataplex_glossary_category, google_dataplex_glossary_term. This makes review significantly more difficult. Please split it into multiple PRs, one per resource.
An override-multiple-resources label can be added to allow merging.

modular-magician · 2025-05-16T07:20:07Z

Tests analytics

Total tests: 56
Passed tests: 54
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataplexGlossaryCategory_update

TestAccDataplexGlossaryTerm_update

Get to know how VCR tests work

modular-magician · 2025-05-16T07:21:17Z

🟢 Tests passed during RECORDING mode:
TestAccDataplexGlossaryCategory_update [Debug log]
TestAccDataplexGlossaryTerm_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…m#13923)

Sachin-Rungta added 30 commits February 18, 2025 05:41

terraform glossary implementation

f225c95

fix-lint

79adfe9

update file name

4971e14

update optional to required

6f704e1

update field

5f093b6

update type

6fc51ff

update yaml

c4cd312

update IAM policy

e268444

updated tmpl code

9c385c3

update tmpl code

cc212f7

remove project from resources

6126d36

updated tmpl

0c31d8c

update unit test

1d3cf6d

update test

be520aa

update test

a0b28e8

update yaml

1d00422

update unit test

16ce8cf

update tmpl

f6c41c8

update test

1534689

add project

930c1f4

update url

c2cc5b5

add version

a0c14ee

update version

76ed34a

add min version

d2ef220

update product.yaml

8d0d91f

update test

d9913d9

Merge remote-tracking branch 'origin' into terraform-glossary

69fdc07

add test

e837d94

update status to beta

d6198b0

typo in provider

0d23ebb

update id

45a13ee

increase timeouts

db3e42e

SirGitsalot approved these changes May 16, 2025

View reviewed changes

SirGitsalot added this pull request to the merge queue May 16, 2025

Merged via the queue into GoogleCloudPlatform:main with commit fde094f May 16, 2025
27 checks passed

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request May 20, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

a099e8b

…m#13923)

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Jun 5, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

3e68605

…m#13923)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jun 25, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

d96d4a1

…m#13923)

jingqizz pushed a commit to jingqizz/magic-modules that referenced this pull request Jul 9, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

125b48c

…m#13923)

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Jul 28, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

7c71285

…m#13923)

NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Sep 4, 2025

Terraform support for Category and Term Resources (GoogleCloudPlatfor…

afe5b78

…m#13923)

Conversation

Sachin-Rungta commented May 13, 2025 • edited by SirGitsalot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

modular-magician commented May 16, 2025

Diff report

Multiple resources added

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 16, 2025

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 16, 2025

Diff report

Multiple resources added

Uh oh!

modular-magician commented May 16, 2025

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 16, 2025

Uh oh!

modular-magician commented May 16, 2025

Diff report

Multiple resources added

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 16, 2025

Uh oh!

modular-magician commented May 16, 2025

Diff report

Multiple resources added

Uh oh!

modular-magician commented May 16, 2025

Tests analytics

Action taken

Uh oh!

modular-magician commented May 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sachin-Rungta commented May 13, 2025 •

edited by SirGitsalot

Loading